fix: Use semantic table to show line numbers to assistive technology #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 99.23% 99.28% +0.05%
==========================================
Files 29 29
Lines 260 280 +20
Branches 31 34 +3
==========================================
+ Hits 258 278 +20
Misses 1 1
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
avinashbot
changed the title
orangevolon
reviewed
May 13, 2025
avinashbot
force-pushed
the
fix-line-numbers-a11y
branch
from
f922ff1 to
5da7710
Compare
jperals
reviewed
May 15, 2025
Member
|
What if one of the two new strings is defined but not the other? Do we want to issue console warnings? |
Member
Author
|
@jperals I did think about console warnings, but I wanted to be a bit cautious for now - I want to look into I18nProvider support as a follow up, and so I didn't want to pull in our special dev-only warnOnce function into the bundle for something most people might not have to think about. |
jperals
previously approved these changes
May 15, 2025
Member
Author
|
@jperals Ah, you're right about the strings. Let me add some docs there. |
jperals
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on further discussion with the accessibility specialists, this seemed to be the best way to go. We already have a tabular structure, so it makes sense for it to be navigable as a table as well (plus, tables are just easy to navigate). That visual change is intentional; it previously started with "This is line number 2" on the first line.
Code view (also other side packages) doesn't have support for I18nProvider, so this won't enable itself unless the strings are completely provided. They should support I18nProvider, of course, but that's a matter for a different time.
Related links, issue #, if available: AWSUI-60236
How has this been tested?
Updated unit tests, tested on VoiceOver and NVDA manually as well. But try it out yourself! Enable VoiceOver, enter the table, and use VO+Arrow Keys. (VO = Control + Option).
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.